Canonicalize tests to @safetestset for isolation#12
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
Closed
Canonicalize tests to @safetestset for isolation#12ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
Convert the Core test group from a single plain @testset wrapping five nested @testset units (sharing module-level f/prob setup) into five independent @safetestset units, each running in its own module. Each unit carries its own self-contained imports (using SciMLIterators, OrdinaryDiffEq, Test) and re-creates the shared f/prob setup. Wrap the QA group's include in @safetestset as well, matching the canonical OrdinaryDiffEq structure. Same tests run with the same assertions; only the isolation wrapping changes. Add SafeTestsets to the test deps ([extras]/[targets].test + [compat]). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Superseded by the v1.2 folder conversion on sciml-testing-rollout (#11). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canonicalizes the test suite so each independent test unit runs in its own module via
@safetestset, matching the OrdinaryDiffEq structure (isolation between tests + world-age safety).Classification
Plain-
@testsetrepo: the Core group was a single@testset "SciMLIterators.jl"wrapping module-levelf/probsetup and five nested@testsetunits; QA was a plaininclude.Changes
test/runtests.jl: each of the five Core units (Solution tuples,Integrator tuples,Integrator intervals,TimeChoiceIterator,Inplace ODE) becomes its own@safetestset. Each carries self-contained imports (using SciMLIterators, OrdinaryDiffEq, Test) and re-creates the small sharedf/probsetup. The outer grouping@testset(whose only file-scope content was that shared setup) is dropped.include(...)is wrapped in@safetestset "Quality Assurance".Project.toml: addedSafeTestsetsto[extras],[targets].test, and[compat]("0.1, 1").No package macros /
$-interpolation in any unit body, so inline@safetestsetbodies are safe (noinclude()indirection needed).Behavior preserved
Same tests, same assertions, unchanged GROUP-dispatch ladder. The two pre-existing
@test_brokenlines in QA are untouched.Verification (local, julia 1.11)
GROUP=Core Pkg.test(): all 5 units pass (31 assertions: 3+9+9+7+3).GROUP=QA Pkg.test(): 7 pass, 2 broken (matching the pre-existing@test_brokencount).Ignore until reviewed by @ChrisRackauckas.